Features/fuzzy search #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features/restfull fuzzy adres
MelvLee
approved these changes
Oct 4, 2021
strijm
reviewed
Oct 4, 2021
| @@ -111,6 +112,7 @@ paths: | |||
| - $ref: '#/components/parameters/huisletter' | |||
| - $ref: '#/components/parameters/huisnummertoevoeging' | |||
| - $ref: '#/components/parameters/exacteMatch' | |||
| - $ref: '#/components/parameters/q' | |||
There was a problem hiding this comment.
Punt 1 onder description mag weg.
Punt 4 (wat punt 3 wordt) zou ik van maken: "Een zoekterm op postcode...."
There was a problem hiding this comment.
Description aangepast. Punt 3 vervalt niet (want nog steeds valide) en ik heb punt "4. Een zoekterm." toegevoegd.
Aanpassing description /adressen n.a.v. opmerking Mark
strijm
approved these changes
Oct 5, 2021
CathyDingemanse
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Op basis van #386 hebben we deze PR gemaakt. De vorige PR was op een achterhaalde branch gedaan.
Afspraak is dat deze branch pas naar develop-1.4 (en daarna naar de master) wordt gemerged als we 100% zeker zijn dat hij in productie gaat.
Mocht deze PR niet in versie 1.4 worden geïmplementeerd dan wordt deze PR geclosed en wordt er naar develop-1.5 gemerged.
Gaarne final review